Michael Cordell's Blog

Reading Ruby Code: ROM - orientation

12 Feb 2017

This is the second part of my on-going series on code reading, the first post can be found here.

In the world of testing methodolgies, there is the concept of “outside-in” testing. The higher level feature tests (how the user will interact with the application) are written first. These higher level tests are used to drive out and guide the development of more granular integration and unit tests, and ultimately the corresponding code. In a similar way, to begin code reading, I prefer to understand the codebase from the perspective of a user. I’d wager that for most developers, the first code you read is not the source code. Rather, it is the usage examples that show you what the library delivers to you as a consumer.

Continuing with our example library ROM.rb, let us orient ourselves to the library as a potential user. If nothing else allows us to break through the blank-page-syndrome of code reading, and find a place to start. Once, you are oriented and understand the general of structure of a code-base, it becomes much easier to look at individual pieces of code and understand how they fit into the larger structure. My general process for orienting myself is to:

  1. Understand the purpose of the project
  2. Build or find a working usage example
  3. Reason about the key parts of the example I say “reason” here, because I will be guessing about how I think the system will work. As I read more, I’ll be checking that against my assumptions. Also, my guessing will likely lead to questions about how things work.

With those three items complete, I feel comfortable enought to begin looking at specific pieces of the system and/or tackling a specific problem.

Project purpose

This feels like an obvious one, and hopefully it is. In order to understand how a project “works” you need to understand what it is trying to do. This understanding should come from the documentation, or more likely, the Github README. In the case of a new job, hopefully it has been well explained to you what the project’s goal is before you look at a line of code. On the opposite side of the fence (for developers and project leads), realize how valuable a statement of purpose is for your project. This is the first thing a new developer, or a user, will need to know about your project. If this isn’t available in the above-the-fold of your project, something is wrong.

neovim purpose devise purpose

In the case of ROM:

rom purpose

While that gives us an idea, of what ROM’s purpose is, to really understand it more you have to dive into the documentation. Luckily ROM includes several introductory pages, among which is a short introductory paragraph as to its goals. For those who do not want to read the introduction, ROM offers a way to manipulate, transform, and store data. It favors de-coupling and separation of the persistence layer from business logic and offers an alternative to the widely used Active Record pattern Note: AR Pattern, not necessarily the library. .

Example

Having working example enables us to ground our understanding in real world usage. I cobbled this example together based on the documentation and the quick start guide:

require 'rom'
require 'rom-sql'
require 'rom-repository'

rom = ROM.container(:sql, 'sqlite::memory') do |conf|
  conf.default.create_table(:users) do
    primary_key :id
    column :name, String, null: false
    column :email, String, null: false
  end
end

class UserRepo < ROM::Repository[:users]
  commands :create

  def by_id(id)
    users.where(id: id).one
  end
end

user_repo = UserRepo.new(rom)

user_repo.create(name: "Jane", email: "jane@doe.org")

puts user_repo.by_id(1).name
#=> "Jane"

This example sets up an in-memory SQLite database and adds one record to it. It then reads the record back and prints a field from it. One nice thing about this example is that what it is doing is fairly obvious In my opinion, I may have some knowledge from reading the documentation while assembling it. But for the most part I think the example’s goal can be inferred directly from the code. . Despite its brevity, this example hits 3 major libraries in ROM (lines 1-3) and demonstrates the major functionality of ROM. As such it is a perfect example for our exercise at hand.

Being able to make this example was a direct by-product of the documentation. If you are entering a closed-source, proprietary project, this type of documentation may not exist. In that case, I would look first at automated tests, failing that I would turn to co-workers or other maintainers. Failing that, you have to begin hunting for what appears to be a logical starting point based on the framework being used. Failing that, you have to read the code to find a logical starting place, but at that point you should be writing a few automatic integration tests to get yourself some coverage.

Understanding the key parts of the example

With a good example in hand, we can begin to find the key structural elements of the project. A worthwhile rule here:

The importance of an item likely correlates well with its place in the loose hierarchy of:

Looking at the above example, we have a module ROM, a class Repository that gets sub-classed as UserRepo. We create two key objects, one called rom and user_repo. Before moving onto looking at major method calls, there is another useful rule:

Look for configuration code, configuration often hints at important parts of the system and gives clues to desired function

For example, if you know that SQLite is a type of database, you can guess that on line 5 we are configuring an SQLite database. Further, you can guess that container setups up the connection to a database, and most likely it supports other types of databases. This hints at the fact that container is likely an important method to understand. The example goes onto define a block that will yield a conf object where more configuration happens.

Even disregarding the configuration part of container it still sticks out as a major method by the fact that it is being called on the root module ROM. Further, its result is passed into the “main” object in the example, the UserRepo initializer (line 21). Other interesting methods are the create call on (line 23) which does the work of creating the row in the DB. Related to that is the commands method in UserRepo which seems to define the method create.

Lines 6-10 appear to create a table with two columns. This looks similar to a Rails database migration in its vernacular. This doesn’t pique my interest, which is actually a good thing. Since I can guess at its behavior I don’t have to prioritize it for investigation. Lines 21 onwards are just exercising the things built above, they are only interesting in so far as showing the importance of the rom object and the create command.

Now onto the stuff I straight don’t understand at first glance. Here’s a list of thoughts:

  1. Hash accessing during sub-classing in line 13 is curious and not very idiomatic in Ruby, definitely worth understanding.
  2. Where does that users method come from on line 17? Likely related to 1
  3. Where do we get that nice DB query syntax for line 17?

Given all of the above, I can reasonably come up with a list of things I want to look for:

This simple process of identifying important items and then key method calls is a solid way of successful code reading. It can easily become a recursive process where once you enter a new class file, you repeat the process and add new key classes and methods to your list. Keep working through your list until you’re finished. I won’t necessarily follow this recursive approach for this blog series, but it is a worthwhile approach for a codebase you will live with for a long period (e.g. a new job).

Finding what you want

Finding files in a project is directly related to how well a project sticks to a convention. The convention does not even have to be adopted outside of the project, it just needs to be consistent. Luckily in the case of ROM, the gems stick to patterns that are widely adopted throughout ruby. Failing a strong convention, you can use grepping to find the class you would like. ROM also has a plugin based architecture that we will explore more in a future article. This means that code is often separated across several repositories, but the setup I outlined in the first post allows us to traverse those repos easily.

In the next article we will seek to answer the questions in this post through further code reading. Thanks for reading!

comments powered by Disqus